twalthr commented on a change in pull request #6927: [FLINK-10624] Extend SQL client end-to-end to test new KafkaTableSink URL: https://github.com/apache/flink/pull/6927#discussion_r232213530
########## File path: flink-end-to-end-tests/flink-sql-client-test-kafka-0.10/pom.xml ########## @@ -0,0 +1,165 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; Review comment: We don't need a Kafka-version specific `pom.xml`. The `flink-sql-client-test/pom.xml` is sufficient. It shouldn't be a problem with both Kafka versions there. The module makes sure that all transitively required Flink modules are build and copies the SQL jars over into a common directory using Maven. The dependency clashes only occur when executing the SQL Client test. This means that the test should exclude clashing jars for SQL statement execution. This has nothing to do with Maven but is a pure test script thing. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
