[
https://issues.apache.org/jira/browse/FLINK-10624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681322#comment-16681322
]
ASF GitHub Bot commented on FLINK-10624:
----------------------------------------
yanghua commented on a change in pull request #6927: [FLINK-10624] Extend SQL
client end-to-end to test new KafkaTableSink
URL: https://github.com/apache/flink/pull/6927#discussion_r232227925
##########
File path: flink-end-to-end-tests/flink-sql-client-test-kafka-0.10/pom.xml
##########
@@ -0,0 +1,165 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0";
Review comment:
@twalthr This
[plugin](https://github.com/apache/flink/blob/master/flink-end-to-end-tests/flink-sql-client-test/pom.xml#L134)
collect jar based on the `classifier `.
We should collect different sets of dependencies for different kafka
connectors. We can't test different kafka connectors but rely on multiple kafka
connectors, which can cause multiple versions of dependency conflicts and you
can't guarantee that you are using a 0.10 kafka client when testing kafka
connector 0.10. There is no guarantee that the Kafka client 2.0 will be tested
when testing kafka connector 2.0. In fact, it may have a combination of kafka
connector 2.0 and kafka client 0.10. cc @pnowojski
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Extend SQL client end-to-end to test new KafkaTableSink
> -------------------------------------------------------
>
> Key: FLINK-10624
> URL: https://issues.apache.org/jira/browse/FLINK-10624
> Project: Flink
> Issue Type: Sub-task
> Components: Kafka Connector, Table API & SQL, Tests
> Affects Versions: 1.7.0
> Reporter: Till Rohrmann
> Assignee: vinoyang
> Priority: Critical
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> With FLINK-9697, we added support for Kafka 2.0. We should also extend the
> existing streaming client end-to-end test to also test the new
> {{KafkaTableSink}} against Kafka 2.0.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
