[
https://issues.apache.org/jira/browse/FLINK-10843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686201#comment-16686201
]
ASF GitHub Bot commented on FLINK-10843:
----------------------------------------
twalthr commented on a change in pull request #7087: [FLINK-10843] [connectors]
Make Kafka table factory versioning more flexible
URL: https://github.com/apache/flink/pull/7087#discussion_r233351993
##########
File path:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSourceSinkFactoryBase.java
##########
@@ -187,9 +190,21 @@
//
--------------------------------------------------------------------------------------------
/**
- * Returns the Kafka version.
+ * Returns a hard-coded Kafka version.
+ *
+ * @deprecated This method can be dropped once we only maintain the
universal Kafka connector.
*/
- protected abstract String kafkaVersion();
+ @Deprecated
+ protected abstract Optional<String> kafkaVersion();
+
+ /**
+ * Returns the pattern that a validator should accept as Kafka version.
+ */
+ protected Pattern[] kafkaVersionPattern() {
Review comment:
I revert my comment from above. The explicit version is still necessary
since Kafka module `10` depends on module `9`, thus both factories are present
in a Kafka 0.10 module. The two factories would interfere with each other if a
hard-coded version is not part of the context.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make Kafka version definition more flexible for new Kafka table factory
> -----------------------------------------------------------------------
>
> Key: FLINK-10843
> URL: https://issues.apache.org/jira/browse/FLINK-10843
> Project: Flink
> Issue Type: Bug
> Components: Kafka Connector, Table API & SQL
> Affects Versions: 1.7.0
> Reporter: Timo Walther
> Assignee: Timo Walther
> Priority: Major
> Labels: pull-request-available
>
> Currently, a user has to specify a specific version for a Kafka connector
> like:
> {code}
> connector:
> type: kafka
> version: "0.11" # required: valid connector versions are "0.8", "0.9",
> "0.10", and "0.11"
> topic: ... # required: topic name from which the table is read
> {code}
> However, the new Kafka connector aims to be universal, thus, at least for 1.x
> and 2.x versions which we should support those as parameters as well.
> Currently, {{2.0}} is the only accepted string for the factory.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
