[
https://issues.apache.org/jira/browse/FLINK-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692001#comment-16692001
]
ASF GitHub Bot commented on FLINK-7243:
---------------------------------------
fhueske commented on a change in pull request #6483:
[FLINK-7243][flink-formats] Add parquet input format
URL: https://github.com/apache/flink/pull/6483#discussion_r234687019
##########
File path:
flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/utils/ParquetRecordReader.java
##########
@@ -0,0 +1,221 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.formats.parquet.utils;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.parquet.column.page.PageReadStore;
+import org.apache.parquet.filter2.compat.FilterCompat;
+import org.apache.parquet.filter2.compat.FilterCompat.Filter;
+import org.apache.parquet.hadoop.ParquetFileReader;
+import org.apache.parquet.hadoop.api.InitContext;
+import org.apache.parquet.hadoop.api.ReadSupport;
+import org.apache.parquet.hadoop.metadata.BlockMetaData;
+import org.apache.parquet.hadoop.metadata.FileMetaData;
+import org.apache.parquet.io.ColumnIOFactory;
+import org.apache.parquet.io.MessageColumnIO;
+import org.apache.parquet.io.RecordReader;
+import org.apache.parquet.io.api.RecordMaterializer;
+import
org.apache.parquet.io.api.RecordMaterializer.RecordMaterializationException;
+import org.apache.parquet.schema.MessageType;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.annotation.CheckReturnValue;
+import javax.annotation.meta.When;
+
+import java.io.IOException;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * Customized {@link org.apache.parquet.hadoop.ParquetRecordReader} that
support start read from particular position.
+ */
+public class ParquetRecordReader<T> {
+ private static final Logger LOG =
LoggerFactory.getLogger(ParquetRecordReader.class);
+
+ private ColumnIOFactory columnIOFactory;
+ private Filter filter;
+ private MessageType readSchema;
+ private MessageType fileSchema;
+ private ReadSupport<T> readSupport;
+
+ // Parquet Materializer convert record to T
+ private RecordMaterializer<T> recordMaterializer;
+ private T currentValue;
+ private long total;
+ private long current = 0;
+ private int currentBlock = -1;
+ private ParquetFileReader reader;
+ private RecordReader<T> recordReader;
+ private boolean strictTypeChecking = true;
+ private boolean skipCorruptedRecord = true;
+ private long countLoadUntilLastGroup = 0;
+ private long totalCountLoadedSoFar = 0;
+
+ public ParquetRecordReader(ReadSupport<T> readSupport, MessageType
readSchema, Filter filter) {
+ this.filter = checkNotNull(filter, "readSupport");
+ this.readSupport = checkNotNull(readSupport, "readSchema");
+ this.readSchema = checkNotNull(readSchema, "filter");
+ }
+
+ public ParquetRecordReader(ReadSupport<T> readSupport, MessageType
readSchema) {
+ this(readSupport, readSchema, FilterCompat.NOOP);
+ }
+
+ public void initialize(ParquetFileReader reader, Configuration
configuration) {
+ this.reader = reader;
+ FileMetaData parquetFileMetadata =
reader.getFooter().getFileMetaData();
+ // real schema of parquet file
+ this.fileSchema = parquetFileMetadata.getSchema();
+ Map<String, String> fileMetadata =
parquetFileMetadata.getKeyValueMetaData();
+ ReadSupport.ReadContext readContext = readSupport.init(new
InitContext(
+ configuration, toSetMultiMap(fileMetadata),
readSchema));
+
+ this.columnIOFactory = new
ColumnIOFactory(parquetFileMetadata.getCreatedBy());
+ this.recordMaterializer = readSupport.prepareForRead(
+ configuration, fileMetadata, readSchema, readContext);
+ this.total = reader.getRecordCount();
+ }
+
+ public void close() throws IOException {
+ if (reader != null) {
+ reader.close();
+ }
+ }
+
+ public void setSkipCorruptedRecord(boolean skipCorruptedRecord) {
+ this.skipCorruptedRecord = skipCorruptedRecord;
+ }
+
+ @CheckReturnValue(when = When.NEVER)
+ public T nextRecord() {
+ return currentValue;
+ }
+
+ public void seek(long syncedBlock, long recordsReadSinceLastSync)
throws IOException {
+ List<BlockMetaData> blockMetaData = reader.getRowGroups();
+ while (syncedBlock > 0) {
+ currentBlock++;
+ reader.skipNextRowGroup();
+ countLoadUntilLastGroup = totalCountLoadedSoFar;
+ totalCountLoadedSoFar +=
blockMetaData.get(currentBlock).getRowCount();
+ syncedBlock--;
+ }
+
+ for (int i = 0; i < recordsReadSinceLastSync; i++) {
+ // skip the record already processed
+ if (hasNextRecord()) {
+ nextRecord();
+ }
+ }
+
+ }
+
+ private RecordReader<T> createRecordReader(PageReadStore pages) throws
IOException {
+ if (pages == null) {
+ throw new IOException("Expecting more rows but reached
last block. Read " + current + " out of " + total);
+ }
+ MessageColumnIO columnIO =
columnIOFactory.getColumnIO(readSchema, fileSchema, strictTypeChecking);
+ RecordReader<T> recordReader = columnIO.getRecordReader(pages,
recordMaterializer, filter);
+ return recordReader;
+ }
+
+ public long getCurrentBlock() {
+ return currentBlock;
+ }
+
+ public long getRecordInCurrentBlock() {
+ if (currentBlock == 0) {
+ return current;
+ } else {
+ return current - countLoadUntilLastGroup;
+ }
+ }
+
+ public boolean reachEnd() {
+ return current >= total;
+ }
+
+ public boolean hasNextRecord() throws IOException {
+ boolean recordFound = false;
+ while (!recordFound) {
+ // no more records left
+ if (current >= total) {
+ return false;
+ }
+
+ try {
+ if (current == totalCountLoadedSoFar) {
+ PageReadStore pages =
reader.readNextRowGroup();
+ recordReader =
createRecordReader(pages);
+ countLoadUntilLastGroup =
totalCountLoadedSoFar;
+ totalCountLoadedSoFar +=
pages.getRowCount();
+ currentBlock++;
+ }
+
+ current++;
+ try {
+ currentValue = recordReader.read();
+ } catch (RecordMaterializationException e) {
+ String errorMessage =
String.format("skipping a corrupt record in block number [%d] record"
+ + "number [%s] of file %s",
currentBlock, current - countLoadUntilLastGroup, reader.getFile());
+
+ LOG.error(errorMessage);
+ if (!skipCorruptedRecord) {
+ throw new
RuntimeException(errorMessage, e);
+ }
+ continue;
+ }
+
+ if (currentValue == null) {
+ current = totalCountLoadedSoFar;
+ LOG.debug("filtered record reader
reached end of block");
+ continue;
+ }
+
+ recordFound = true;
+ LOG.debug("read value: {}", currentValue);
+ } catch (RuntimeException e) {
Review comment:
This is a very generic exception. What kind of error are we expecting here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add ParquetInputFormat
> ----------------------
>
> Key: FLINK-7243
> URL: https://issues.apache.org/jira/browse/FLINK-7243
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: godfrey he
> Assignee: Zhenqiu Huang
> Priority: Major
> Labels: pull-request-available
>
> Add a {{ParquetInputFormat}} to read data from a Apache Parquet file.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
