zhijiangW commented on a change in pull request #6705: [FLINK-10356][network]
add sanity checks to SpillingAdaptiveSpanningRecordDeserializer
URL: https://github.com/apache/flink/pull/6705#discussion_r234920588
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/misc/CustomSerializationITCase.java
##########
@@ -62,127 +68,103 @@ public static Configuration getConfiguration() {
}
@Test
- public void testIncorrectSerializer1() {
- try {
- ExecutionEnvironment env =
ExecutionEnvironment.getExecutionEnvironment();
- env.setParallelism(PARLLELISM);
- env.getConfig().disableSysoutLogging();
+ public void testIncorrectSerializer1() throws Exception {
Review comment:
I think the following codes can be deduplicated from four tests at least if
`T` is not easy to be handled for complete deduplication?
`
expectedException.expect(JobExecutionException.class);
expectedException.expectCause(Matchers.both(isA(IOException.class))
.and(hasProperty("message", containsString("broken serialization"))));
ExecutionEnvironment env = ExecutionEnvironment.getExecutionEnvironment();
env.setParallelism(PARLLELISM);
env.getConfig().disableSysoutLogging();
`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
