imamitsehgal commented on a change in pull request #7153: FLINK-10918 Fix the
checkpoint dir creation error on Window for keyed rocksdb state
URL: https://github.com/apache/flink/pull/7153#discussion_r236042001
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
##########
@@ -575,7 +585,7 @@ private RocksDB openDB(
try {
dbRef = RocksDB.open(
Preconditions.checkNotNull(dbOptions),
- Preconditions.checkNotNull(path),
+
Preconditions.checkNotNull(Utils.getPathAsString(new Path(path))),
Review comment:
If Path is null or "" then new Path(path) will throw runtime
IllegalArgumentException. The path returned by getPathAsString will be checked
again to be non-null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
