pnowojski commented on a change in pull request #6787: [FLINK-8577][table]
Implement proctime DataStream to Table upsert conversion
URL: https://github.com/apache/flink/pull/6787#discussion_r236195894
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/RelTimeIndicatorConverter.scala
##########
@@ -165,7 +165,30 @@ class RelTimeIndicatorConverter(rexBuilder: RexBuilder)
extends RelShuttle {
override def visit(exchange: LogicalExchange): RelNode =
throw new TableException("Logical exchange in a stream environment is not
supported yet.")
- override def visit(scan: TableScan): RelNode = scan
+ override def visit(scan: TableScan): RelNode = {
+ val upsertStreamTable = scan.getTable.unwrap(classOf[UpsertStreamTable[_]])
+ val relTypes = scan.getRowType.getFieldList.map(_.getType)
+ val getTimeIndicatorIndexes = relTypes.zipWithIndex
+ .filter(e => FlinkTypeFactory.isTimeIndicatorType(e._1))
+ .map(_._2)
+ if (upsertStreamTable != null) {
+ val input = if (getTimeIndicatorIndexes.size > 0) {
+ // materialize time indicator
+ val rewrittenScan = scan.copy(scan.getTraitSet, scan.getInputs)
+ materializerUtils.projectAndMaterializeFields(rewrittenScan,
getTimeIndicatorIndexes.toSet)
+ } else {
+ scan
+ }
+
+ LogicalLastRow.create(
Review comment:
But you could probably add this node when changing convention. We assume
that `TabelScan` rel node represents all kinds of table scans and it always can
produce retractions, while for some stage (`FlinkLogical`?) we freeze it to
either retractions/upserts.
Regardless of that, `RelTimeIndicatorConverter.scala` is not the right place
to create `LogicalLastRow`. You could also add a single pass rule, that is
applied only once, that inserts upsert -> retraction conversion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
