[
https://issues.apache.org/jira/browse/FLINK-10712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16699078#comment-16699078
]
ASF GitHub Bot commented on FLINK-10712:
----------------------------------------
StefanRRichter commented on a change in pull request #7009: [FLINK-10712]
Support to restore state when using RestartPipelinedRegionStrategy
URL: https://github.com/apache/flink/pull/7009#discussion_r236284582
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -1073,6 +1073,108 @@ public boolean restoreLatestCheckpointedState(
}
}
+ /**
+ * Restores the latest checkpointed state at the granularity of
execution vertex.
+ *
+ * @param executionVertices Set of execution vertices to restore. State
for these vertices is
+ * restored via {@link
Execution#setInitialState(JobManagerTaskRestore)}.
+ * @param errorIfNoCheckpoint Fail if no completed checkpoint is
available to
+ * restore from.
+ * @param allowNonRestoredState Allow checkpoint state that cannot be
mapped
+ * to any jobID vertex in tasks.
+ * @return <code>true</code> if state was restored, <code>false</code>
otherwise.
+ * @throws IllegalStateException If the CheckpointCoordinator is shut
down.
+ * @throws IllegalStateException If no completed checkpoint is
available and
+ * the <code>failIfNoCheckpoint</code>
flag has been set.
+ * @throws IllegalStateException If the checkpoint contains state that
cannot be
+ * mapped to any jobID vertex in
<code>tasks</code> and the
+ * <code>allowNonRestoredState</code>
flag has not been set.
+ * @throws IllegalStateException If the max parallelism changed for an
operator
+ * that restores state from this
checkpoint.
+ * @throws IllegalStateException If the parallelism changed for an
operator
+ * that restores <i>non-partitioned</i>
state from this
+ * checkpoint.
+ */
+ public boolean restoreLatestCheckpointedState(
Review comment:
Again, this is almost a complete duplication of the original method. We
should unify boths methods to keep this maintainable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> RestartPipelinedRegionStrategy does not restore state
> -----------------------------------------------------
>
> Key: FLINK-10712
> URL: https://issues.apache.org/jira/browse/FLINK-10712
> Project: Flink
> Issue Type: Bug
> Components: Distributed Coordination
> Affects Versions: 1.3.3, 1.4.2, 1.5.5, 1.6.2, 1.7.0
> Reporter: Stefan Richter
> Assignee: Yun Tang
> Priority: Critical
> Labels: pull-request-available
> Fix For: 1.8.0
>
>
> RestartPipelinedRegionStrategy does not perform any state restore. This is
> big problem because all restored regions will be restarted with empty state.
> We need to take checkpoints into account when restoring.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
