twalthr commented on a change in pull request #7177: [FLINK-7599] [table]
Support for aggregates in MATCH_RECOGNIZE
URL: https://github.com/apache/flink/pull/7177#discussion_r237422016
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
##########
@@ -1169,6 +1169,94 @@ object AggregateUtil {
(propPos._1, propPos._2, propPos._3)
}
+ private[flink] def transformToAggregateFunction(
+ aggregateCall: SqlAggFunction,
+ isDistinct: Boolean,
+ aggregateInputType: Seq[RelDataType],
+ needRetraction: Boolean,
+ tableConfig: TableConfig,
+ isStateBackedDataViews: Boolean = false,
Review comment:
Remove the default here and at other places. Implementers should explicitly
state what they want.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
