zjffdu commented on a change in pull request #7121: [FLINK-9555]Support table
api in scala shell
URL: https://github.com/apache/flink/pull/7121#discussion_r237735688
##########
File path:
flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITCase.scala
##########
@@ -168,6 +168,56 @@ class ScalaShellITCase extends TestLogger {
Assert.assertTrue(output.contains("WC(world,10)"))
}
+ @Test
+ def testSimpleSelectWithFilterBatchTableAPIQuery: Unit = {
+ val input =
+ """
+ |import _root_.scala.collection.mutable
+ |val data = new mutable.MutableList[(Int, Long, String)]
+ | data.+=((1, 1L, "Hi"))
+ | data.+=((2, 2L, "Hello"))
+ | data.+=((3, 2L, "Hello world"))
+ |val t = benv.fromCollection(data).toTable(btenv, 'a, 'b,
'c).select("*").where('a % 2 === 1 )
Review comment:
MutableList is not necessary here. Use this instead
```
val data = Seq(
(1, 1L, "Hi),
(2, 2L, "Hello"),
(3, 2L, "Hello world")
)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
