[
https://issues.apache.org/jira/browse/FLINK-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707391#comment-16707391
]
ASF GitHub Bot commented on FLINK-10457:
----------------------------------------
kl0u commented on a change in pull request #6774: [FLINK-10457] Support
SequenceFile for StreamingFileSink
URL: https://github.com/apache/flink/pull/6774#discussion_r238316598
##########
File path:
flink-formats/flink-sequencefile/src/main/java/org/apache/flink/formats/sequencefile/SequenceFileWriter.java
##########
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.formats.sequencefile;
+
+import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.api.common.serialization.BulkWriter;
+import org.apache.flink.api.java.tuple.Tuple2;
+
+import org.apache.hadoop.io.SequenceFile;
+import org.apache.hadoop.io.Writable;
+
+import java.io.IOException;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * A {@link BulkWriter} implementation that wraps a {@link
SequenceFile.Writer}.
+ *
+ * @param <K> The type of key written.
+ * @param <V> The type of value written.
+ */
+@PublicEvolving
+public class SequenceFileWriter<K extends Writable, V extends Writable>
implements BulkWriter<Tuple2<K, V>> {
+ private final SequenceFile.Writer writer;
+
+ public SequenceFileWriter(SequenceFile.Writer writer) {
+ this.writer = checkNotNull(writer, "sequenceFileWriter");
+ }
+
+ @Override
+ public void addElement(Tuple2<K, V> element) throws IOException {
+ writer.append(element.f0, element.f1);
+ }
+
+ @Override
+ public void flush() throws IOException {
+ writer.hflush();
Review comment:
Here `writer.hsync()` should be called, not `hflush()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support SequenceFile for StreamingFileSink
> ------------------------------------------
>
> Key: FLINK-10457
> URL: https://issues.apache.org/jira/browse/FLINK-10457
> Project: Flink
> Issue Type: New Feature
> Components: Streaming Connectors
> Reporter: Jihyun Cho
> Priority: Major
> Labels: pull-request-available
>
> SequenceFile is major file format in Hadoop eco system.
> It is simple to manage file and easy to combine with other tools.
> So we are still needed SequenceFile format, even if the file format supports
> Parquet and ORC.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
