sunjincheng121 commented on a change in pull request #6918:
[FLINK-10543][table] Leverage efficient timer deletion in relational operators
URL: https://github.com/apache/flink/pull/6918#discussion_r238470724
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/NonWindowJoin.scala
##########
@@ -18,7 +18,7 @@
package org.apache.flink.table.runtime.join
import org.apache.flink.api.common.functions.FlatJoinFunction
-import org.apache.flink.api.common.state.{MapState, MapStateDescriptor,
ValueState, ValueStateDescriptor}
+import org.apache.flink.api.common.state._
Review comment:
Do you think we can extract a `CoProcessFunctionWithCleanupState` which can
be share all operation of two sides？just a suggestion, I'm fine keep current
state.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
