azagrebin commented on a change in pull request #7118: [FLINK-10482] Fix double
counting of checkpoint stat
URL: https://github.com/apache/flink/pull/7118#discussion_r238720755
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointStatsCounts.java
##########
@@ -181,4 +183,15 @@ CheckpointStatsCounts createSnapshot() {
numCompletedCheckpoints,
numFailedCheckpoints);
}
+
+ private boolean assertDecrementOfInProgressCheckpointsNumber() {
+ boolean decrementLeadsToNegativeNumber =
numInProgressCheckpoints - 1 < 0;
+ if (decrementLeadsToNegativeNumber) {
+ String errorMessage = "Incremented the completed number
of checkpoints " +
+ "without incrementing the in progress
checkpoints before.";
+ LOG.warn(errorMessage);
+ LOG.debug("Inconsistent CheckpointStatsCounts", new
IllegalStateException(errorMessage));
Review comment:
thanks, debugging leftover
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
