walterddr commented on a change in pull request #7253: [FLINK-11074] [table][tests] Enable harness tests with RocksdbStateBackend and add harness tests for CollectAggFunction URL: https://github.com/apache/flink/pull/7253#discussion_r240321103
########## File path: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/harness/HarnessTestBase.scala ########## @@ -491,13 +489,75 @@ class HarnessTestBase { distinctCountFuncName, distinctCountAggCode) + def createHarnessTester[KEY, IN, OUT]( + dataStream: DataStream[_], + prefixOperatorName: String) + : KeyedOneInputStreamOperatorTestHarness[KEY, IN, OUT] = { + + val transformation = extractExpectedTransformation( + dataStream.javaStream.getTransformation, + prefixOperatorName).asInstanceOf[OneInputTransformation[_, _]] + if (transformation == null) { + throw new Exception("Can not find the expected transformation") + } + + val processOperator = transformation.getOperator.asInstanceOf[OneInputStreamOperator[IN, OUT]] + val keySelector = transformation.getStateKeySelector.asInstanceOf[KeySelector[IN, KEY]] + val keyType = transformation.getStateKeyType.asInstanceOf[TypeInformation[KEY]] + + createHarnessTester(processOperator, keySelector, keyType) + .asInstanceOf[KeyedOneInputStreamOperatorTestHarness[KEY, IN, OUT]] + } + + private def extractExpectedTransformation( + transformation: StreamTransformation[_], + prefixOperatorName: String): StreamTransformation[_] = { + def extractFromInputs(inputs: StreamTransformation[_]*): StreamTransformation[_] = { + for (input <- inputs) { + val t = extractExpectedTransformation(input, prefixOperatorName) + if (t != null) { + return t + } + } + null + } + + transformation match { + case one: OneInputTransformation[_, _] => + if (one.getName.startsWith(prefixOperatorName)) { + one + } else { + extractExpectedTransformation(one.getInput, prefixOperatorName) + } + case two: TwoInputTransformation[_, _, _] => Review comment: Let's throw unsupported operation for now, since there's no code path that executes two input transform yet. we can always add this logic later when necessary. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services