Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1048#discussion_r37753243
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java ---
    @@ -123,12 +122,12 @@ public static InetSocketAddress 
getJobManagerAddress(Configuration config) throw
         * @throws org.apache.flink.runtime.client.JobExecutionException Thrown 
if the job
         *                                                               
execution fails.
         */
    -   public static SerializedJobExecutionResult submitJobAndWait(
    +   public static JobExecutionResult submitJobAndWait(
                        ActorSystem actorSystem,
                        ActorGateway jobManagerGateway,
                        JobGraph jobGraph,
                        FiniteDuration timeout,
    -                   boolean sysoutLogUpdates) throws JobExecutionException {
    +                   boolean sysoutLogUpdates, ClassLoader 
usercodeClassloader) throws JobExecutionException {
    --- End diff --
    
    Style: Why appending the new parameter to the last line when all the other 
parameters are written in a new line?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to