[ https://issues.apache.org/jira/browse/FLINK-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718401#comment-16718401 ]
Dian Fu commented on FLINK-11067: --------------------------------- Hi [~twalthr], Thanks a lot for the solution. Agree with you that we should expose interfaces instead of implementations. I have some quick questions and looking forward to your reply: 1. Regarding to the return type BatchTableEnvironment of the following API: {code:java} static BatchTableEnvironment getTableEnvironment(BatchEnvironment env);{code} What's the package name of BatchTableEnvironment? Seems that the backwards compatibility will always be broken no matter what it is. 2. The facade class for Batch/StreamTableEnvironment needs to consider for both Scala and Java or we will have separate facade classes for Scala and Java? > Port TableEnvironments to Java > ------------------------------ > > Key: FLINK-11067 > URL: https://issues.apache.org/jira/browse/FLINK-11067 > Project: Flink > Issue Type: Sub-task > Components: Table API & SQL > Reporter: Timo Walther > Assignee: Dawid Wysakowicz > Priority: Major > > This task includes porting {{TableEnvironment}}, {{StreamTableEnvironment}}, > {{BatchTableEnvironment}} to Java. API-breaking changes need to be avoided > and discussed. Some refactoring and clean up might be necessary. -- This message was sent by Atlassian JIRA (v7.6.3#76005)