walterddr commented on a change in pull request #7263: [FLINK-11081] Support binding port range for REST server URL: https://github.com/apache/flink/pull/7263#discussion_r240877630
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestServerEndpoint.java ########## @@ -181,14 +184,44 @@ protected void initChannel(SocketChannel ch) { .channel(NioServerSocketChannel.class) .childHandler(initializer); - log.debug("Binding rest endpoint to {}:{}.", restBindAddress, restBindPort); - final ChannelFuture channel; - if (restBindAddress == null) { - channel = bootstrap.bind(restBindPort); - } else { - channel = bootstrap.bind(restBindAddress, restBindPort); + ChannelFuture channel; + + // parse port range definition and create port iterator + Iterator<Integer> portsIterator; + try { + portsIterator = NetUtils.getPortRangeFromString(restBindPort); + } catch (Exception e) { Review comment: hmm. `IllegalConfigurationException` extends `RuntimeException`, shouldn't we not catch that? I am wondering reason `BootstrapTool` handles it that way was because the static `startActorSystem` method throws general exception in method signature. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services