yanghua commented on issue #7263: [FLINK-11081] Support binding port range for 
REST server
URL: https://github.com/apache/flink/pull/7263#issuecomment-446460550
 
 
   `ConfigOption.PORT` ? I can not find it. 
   I guess what you want to express is `RestOptions.PORT`. I think that it 
can't be deprecated here. Initially its responsibilities are both the binding 
port of the server and the connection port of the client. Now the server's 
binding port is represented by `BIND_PORT`, then it can also be used to 
represent the client's connection port. In some places it may be used:
   
   ```
   Private void createClientConfiguration(URI restAddress) {
   Configuration restClientConfig = new Configuration();
   restClientConfig.setString(JobManagerOptions.ADDRESS, restAddress.getHost());
   restClientConfig.setInteger(RestOptions.PORT, restAddress.getPort());
   this.restClusterClientConfig = new 
UnmodifiableConfiguration(restClientConfig);
   }
   ```
   
   There should be two pairs of configuration items `BIND_ADDRESS/BIND_PORT` 
and `ADDRESS/PORT` here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to