[ 
https://issues.apache.org/jira/browse/FLINK-11081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718467#comment-16718467
 ] 

ASF GitHub Bot commented on FLINK-11081:
----------------------------------------

yanghua edited a comment on issue #7263: [FLINK-11081] Support binding port 
range for REST server
URL: https://github.com/apache/flink/pull/7263#issuecomment-446460550
 
 
   `ConfigOption.PORT` ? I can not find it. 
   I guess what you want to express is `RestOptions.PORT`. I think that it 
can't be deprecated here. Initially its responsibilities are both the binding 
port of the server and the connection port of the client. Now the server's 
binding port is represented by `BIND_PORT`, then it can also be used to 
represent the client's connection port. In some places it may be used:
   
   ```java
   Private void createClientConfiguration(URI restAddress) {
       Configuration restClientConfig = new Configuration();
       restClientConfig.setString(JobManagerOptions.ADDRESS, 
restAddress.getHost());
       restClientConfig.setInteger(RestOptions.PORT, restAddress.getPort());
       this.restClusterClientConfig = new 
UnmodifiableConfiguration(restClientConfig);
   }
   ```
   
   There should be two pairs of configuration items `BIND_ADDRESS/BIND_PORT` 
and `ADDRESS/PORT` here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support binding port range for REST server
> ------------------------------------------
>
>                 Key: FLINK-11081
>                 URL: https://issues.apache.org/jira/browse/FLINK-11081
>             Project: Flink
>          Issue Type: Improvement
>          Components: REST
>    Affects Versions: 1.7.0, 1.8.0
>            Reporter: Till Rohrmann
>            Assignee: vinoyang
>            Priority: Major
>              Labels: pull-request-available
>
> Currently the {{RestServerEndpoint}} binds to the port specified by 
> {{RestOptions#PORT}}. {{PORT}} is of type integer. Sometimes, it would be 
> useful to being able to specify not only a single port but a port range to 
> pick a port from. Therefore, I propose to add similar to 
> {{RestOptions#BIND_ADDRESS}} another option {{RestOptions#BIND_PORT}} which 
> allows to specify a port range for the {{RestServerEndpoint}} to pick a port 
> from. {{RestOptions#PORT}} would then only be used by the client to connect 
> to the started {{RestServerEndpoint}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to