pnowojski commented on a change in pull request #6871:
[FLINK-10583][FLINK-10584][table] Add State Retention to temporal joins.
URL: https://github.com/apache/flink/pull/6871#discussion_r240996365
##########
File path:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/harness/TemporalJoinHarnessTest.scala
##########
@@ -530,6 +530,215 @@ class TemporalJoinHarnessTest extends HarnessTestBase {
0)
}
+ // ---------------------- Row time TTL tests ----------------------
+
+ @Test
+ def testRowTimeJoinCleanupTimerUpdatedFromProbeSide(): Unit = {
+ // min=2ms max=4ms
+ val testHarness = createTestHarness(new
OrdersRatesRowtimeTemporalJoinInfo())
+
+ testHarness.open()
+ val expectedOutput = new ConcurrentLinkedQueue[Object]()
+
+ testHarness.setProcessingTime(1L)
+
+ // process without conversion rates
+ testHarness.processElement1(new StreamRecord(CRow(2L, "Euro", 1L)))
+ testHarness.processElement2(new StreamRecord(CRow("Euro", 114L, 0L)))
+
+ expectedOutput.add(new StreamRecord(CRow(2L, "Euro", 1L, "Euro", 114L,
0L)))
+
+ testHarness.advanceWatermark(new Watermark(2L))
+
+ // this should update the clean-up timer to 8
+ testHarness.setProcessingTime(4L)
+ testHarness.processElement1(new StreamRecord(CRow(2L, "Euro", 4L)))
+
+ expectedOutput.add(new StreamRecord(CRow(2L, "Euro", 4L, "Euro", 114L,
0L)))
+
+ // this should now do nothing (also it does not update the timer as 5 +
2ms (min) < 8)
+ testHarness.setProcessingTime(5L)
+
+ testHarness.processElement1(new StreamRecord(CRow(2L, "Euro", 5L)))
+ expectedOutput.add(new StreamRecord(CRow(2L, "Euro", 5L, "Euro", 114L,
0L)))
+
+ testHarness.advanceWatermark(new Watermark(5L))
+
+ // this should now clean up the state
+ testHarness.setProcessingTime(8L)
+
+ testHarness.processElement1(new StreamRecord(CRow(2L, "Euro", 7L))) //
this should find no match
+
+ testHarness.advanceWatermark(new Watermark(10L))
+
+ verify(expectedOutput, testHarness.getOutput)
+
+ testHarness.close()
+ }
+
+ @Test
+ def testRowTimeJoinCleanupTimerUpdatedFromBuildSide(): Unit = {
+ // min=2ms max=4ms
+ val testHarness = createTestHarness(new
OrdersRatesRowtimeTemporalJoinInfo())
+
+ testHarness.open()
+ val expectedOutput = new ConcurrentLinkedQueue[Object]()
+
+ testHarness.setProcessingTime(1L)
+
+ // process without conversion rates
+ testHarness.processElement1(new StreamRecord(CRow(2L, "Euro", 1L)))
+ testHarness.processElement2(new StreamRecord(CRow("Euro", 114L, 0L)))
+
+ expectedOutput.add(new StreamRecord(CRow(2L, "Euro", 1L, "Euro", 114L,
0L)))
+
+ testHarness.advanceWatermark(new Watermark(2L))
+
+ // this should update the clean-up timer to 8
+ testHarness.setProcessingTime(4L)
+ testHarness.processElement2(new StreamRecord(CRow("Euro", 117L, 4L)))
+
+ // this should now do nothing
+ testHarness.setProcessingTime(5L)
+
+ // so this should be joined with the "old" value
+ testHarness.processElement1(new StreamRecord(CRow(2L, "Euro", 3L)))
+ expectedOutput.add(new StreamRecord(CRow(2L, "Euro", 3L, "Euro", 114L,
0L)))
+
+ testHarness.advanceWatermark(new Watermark(5L))
+
+ // this should now clean up the state
+ testHarness.setProcessingTime(8L)
+
+ testHarness.processElement1(new StreamRecord(CRow(2L, "Euro", 7L))) //
this should find no match
+
+ testHarness.advanceWatermark(new Watermark(10L))
+
+ verify(expectedOutput, testHarness.getOutput)
+
+ testHarness.close()
+ }
+
+ @Test
+ def testRowTimeJoinCleanupTimerUpdatedAfterEvaluation(): Unit = {
+ // min=2ms max=4ms
+ val testHarness = createTestHarness(new
OrdersRatesRowtimeTemporalJoinInfo())
+
+ testHarness.open()
+ val expectedOutput = new ConcurrentLinkedQueue[Object]()
+
+ testHarness.setProcessingTime(1L)
+
+ // process without conversion rates
Review comment:
you can drop `// process without conversion rates` comment from your tests,
since it's irrelevant for your test cases (in your processing time tests it's
event incorrect & misleading). In the preexisting test this comment is meant to
differentiate between two tested cases when `processElement1` &
`processElement2` are being called in different order. You are using always one
order, so the comment is irrelevant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
