GJL commented on issue #7302: [FLINK-11156] [tests] Reconcile powermock with JDK 9 URL: https://github.com/apache/flink/pull/7302#issuecomment-447380751 Thank you for your contribution to Apache Flink @TisonKun I think an additional constructor annotated with `@VisibleForTesting` is more maintainable. The current solution has the following downsides: - It is not obvious why `Comparator.comparing` does not work. The next person might try to refactor it back to the old solution and break java 9 compatibility. - The test uses powermock which might break again in later java versions. Let me loop in @tillrohrmann, the original author of the test. What do you think?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
