StefanRRichter commented on a change in pull request #7288: [FLINK-9702] Improvement in (de)serialization of keys and values for RocksDB state URL: https://github.com/apache/flink/pull/7288#discussion_r241839041
########## File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBSerializedCompositeKeyBuilder.java ########## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.contrib.streaming.state; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.annotation.VisibleForTesting; +import org.apache.flink.api.common.typeutils.TypeSerializer; +import org.apache.flink.core.memory.DataOutputSerializer; +import org.apache.flink.util.FlinkRuntimeException; + +import javax.annotation.Nonnegative; +import javax.annotation.Nonnull; +import javax.annotation.concurrent.NotThreadSafe; + +import java.io.IOException; + +/** + * Responsible for serialization of currentKey, currentGroup and namespace. + * Will reuse the previous serialized currentKeyed if possible. + * @param <K> type of the key. + */ +@NotThreadSafe +@Internal +class RocksDBSerializedCompositeKeyBuilder<K> { + + /** The serializer for the key. */ + @Nonnull + private final TypeSerializer<K> keySerializer; + + /** The output to write the key into. */ + @Nonnull + private final DataOutputSerializer keyOutView; + + /** The number of Key-group-prefix bytes for the key. */ + @Nonnegative + private final int keyGroupPrefixBytes; + + /** This flag indicates whether the key type has a variable byte size in serialization. */ + private final boolean keySerializerTypeVariableSized; + + /** Mark for the position after the serialized key. */ + @Nonnegative + private int afterKeyMark; + + public RocksDBSerializedCompositeKeyBuilder( Review comment: We don't strictly need it, but I think this can be useful for tools like Bravo. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
