azagrebin commented on a change in pull request #6777: [FLINK-10461] [State 
Backends, Checkpointing] Speed up download files when restore from DFS
URL: https://github.com/apache/flink/pull/6777#discussion_r242903778
 
 

 ##########
 File path: 
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackend.java
 ##########
 @@ -686,6 +697,17 @@ public RocksDBNativeMetricOptions 
getMemoryWatcherOptions() {
                return options;
        }
 
+       /**
+        * Gets the thread number will used for downloading files from DFS when 
restore.
+        */
+       public int getNumberOfRestoringThreads() {
+               return numberOfRestoringThreads == -1 ? 
RocksDBOptions.CHECKPOINT_RESTORE_THREAD_NUM.defaultValue() : 
numberOfRestoringThreads;
 
 Review comment:
   Let's keep it in sync with the logic for `enableIncrementalCheckpointing` 
for now. 
   Later, we can revisit/refactor the backend configuration.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to