hequn8128 commented on a change in pull request #7373: [FLINK-11227] [table] 
The DescriptorProperties contains some bounds checking errors
URL: https://github.com/apache/flink/pull/7373#discussion_r244271361
 
 

 ##########
 File path: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/DescriptorPropertiesTest.scala
 ##########
 @@ -165,4 +182,26 @@ class DescriptorPropertiesTest {
       minLength,
       maxLength)
   }
+
+  private def testFixedFieldsValidation(properties: DescriptorProperties): 
Unit = {
 
 Review comment:
   How about rename `testFixedFieldsValidation` to 
`testFixedIndexedPropertiesValidation`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to