twalthr commented on a change in pull request #7271: [FLINK-11124][table] Add private[flink] to TemporalTableFunction.create() method URL: https://github.com/apache/flink/pull/7271#discussion_r245321721
########## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/TemporalTableFunction.scala ########## @@ -65,7 +65,7 @@ class TemporalTableFunction private( } object TemporalTableFunction { - def create( + private[flink] def create( Review comment: @hequn8128 we could also remove this method entirely. What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services