Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/992#discussion_r37879401
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/SocketTextStreamFunction.java
---
@@ -42,11 +42,13 @@
private boolean retryForever;
private Socket socket;
private static final int CONNECTION_TIMEOUT_TIME = 0;
- private static final int CONNECTION_RETRY_SLEEP = 1000;
+ public static int CONNECTION_RETRY_SLEEP = 1000;
--- End diff --
This shouldn't be modifiable by everyone. Please make it just
package-visible by removing the `public` modifier. Also, please keep the
`final` modifier because the current implementation just lets the number of
retries be configurable with a fixed 1 second retry rate. This is also
documented in the user-facing API methods on DataStream.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
