zentol opened a new pull request #7456: [FLINK-11289][examples] Rework examples to account for licensing URL: https://github.com/apache/flink/pull/7456 ## What is the purpose of the change This PR adds separate fat-jar modules for the twitter and state-machine examples so that we can properly handle licenses for them. These jars have been bundling dependencies without any license files, requiring us to handle these dependencies in the flink-dist NOTICE-binary manually. These modules work similar to the `flink-sql-connector` modules in that they do not contain any code themselves; they are purely used for assembling a jar with proper licensing. These jars are not deployed to maven, and only included in flink-dist. Additionally this PR fixes an issue where transformers defined child-modules would disabled the NOTICE file transformer. ## Brief change log * add new `flink-examples-build-helper` module * add sub modules for each example * add licensing to new modules * move shade-plugin configuration for jar assembly from flink-examples-streaming to respective module * update flink-dist assembly to account for new modules ## Verifying this change Manually verified. Ran both examples on a local cluster and inspected jar contents. The state-machine jar no longer includes classes from flink-core that were accidentally pulled in. The Twitter jar no longer bundles chill that was accidentally pulled in.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services