FaxianZhao commented on a change in pull request #7344: [FLINK-4369] Optimize
evict performance for the TriggerResult.FIRE_AND_PURGE
URL: https://github.com/apache/flink/pull/7344#discussion_r247088129
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperator.java
##########
@@ -179,7 +179,7 @@ public void merge(W mergeResult,
// if we have no state, there
is nothing to do
continue;
}
- emitWindowContents(actualWindow,
contents, evictingWindowState);
+ emitWindowContents(actualWindow,
contents, evictingWindowState, triggerResult.isPurge());
}
if (triggerResult.isPurge()) {
Review comment:
Good idea. Merge emit and purge in the function `emitWindowContents` and
rename it as `triggerWindowContents`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
