zhijiangW opened a new pull request #7549: [FLINK-11403][network] Remove 
ResultPartitionConsumableNotifier from ResultPartition
URL: https://github.com/apache/flink/pull/7549
 
 
   ## What is the purpose of the change
   
   *This is the precondition for introducing pluggable `ShuffleService` on TM 
side.*
   
   *In current process of creating `ResultPartition`, the 
`ResultPartitionConsumableNotifier` regarded as TM level component has to be 
passed into the constructor. In order to create `ResultPartition` easily via 
`ShuffleService`, the required information should be covered by 
`ResultPartitionDeploymentDescriptor` as much as possible, then we could remove 
this notifier from the constructor. And it is also reasonable for notifying 
consumable partition via `TaskActions` which is already covered in 
`ResultPartition`.*
   
   ## Brief change log
   
     - *Remove `ResultPartitionConsumableNotifier` from `ResultPartition` 
constructor*
     - *Introduce `notifyPartitionConsumable` for `TaskActions` interface*
     - *Make `NoOpTaskActions` implementation public class for tests usage*
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as 
*ResultPartitionTest*.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to