pnowojski commented on issue #7405: [FLINK-11249] FlinkKafkaProducer011 can not 
be migrated to FlinkKafkaProducer
URL: https://github.com/apache/flink/pull/7405#issuecomment-457577382
 
 
   Thanks again for your help in solving this issue @tvielgouarin! Much 
appreciated. 
   
   I checked the code and played a little bit with your implementation. Your 
`FlinkKafkaProducerMigrationTest` looks correct, but before we deal with this 
failure prerequisite is to have such state of the migration code, that the 
following simplest test should also be working:
   ```
        @Test
        public void testReuseKafkaTempDirectory() throws Exception {
                assertExactlyOnceForTopic(createProperties(), topic, 0, 
Arrays.asList(43));
        }
   ```  
   It should work, since in `writeSnapshot` you 
`testHarness.notifyOfCompletedCheckpoint(1L);` for the stored snapshot before 
closing KafkaProducer. The issue that I was referring in the Jira would be if 
you would comment out `notifyOfCompletedCheckpoint(1L)` call - that would leave 
"pending" open transactions in Kafka. But before we tackle this one, 
`testReuseKafkaTempDirectory` should be passing.
   
   I think the issue might be that you didn't back up the ZooKeeper state. As 
far as I remember (and [this 
article](https://www.digitalocean.com/community/tutorials/how-to-back-up-import-and-migrate-your-apache-kafka-data-on-ubuntu-18-04)
 confirms that) backup-ing some ZooKeeper directories is also necessary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to