tzulitai commented on a change in pull request #7590: [FLINK-11329][core] 
Migrating CompositeSerializers
URL: https://github.com/apache/flink/pull/7590#discussion_r252130677
 
 

 ##########
 File path: 
flink-end-to-end-tests/flink-stream-state-ttl-test/src/main/java/org/apache/flink/streaming/tests/verify/ValueWithTs.java
 ##########
 @@ -56,8 +57,8 @@ public String toString() {
        /** Serializer for Serializer. */
        public static class Serializer extends 
CompositeSerializer<ValueWithTs<?>> {
 
 Review comment:
   This serializer class previously did not have a `serialVersionUID` defined.
   Need to explicitly set it to what it was before, because I guess the serial 
version UID would have changed when adding the new constructors.
   
   OTOH, there seems to be missing a migration test for this serializer, 
because that would have caught this problem.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to