[
https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14713515#comment-14713515
]
ASF GitHub Bot commented on FLINK-2111:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37988097
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -491,9 +495,58 @@ public void cancel(JobID jobId) throws Exception {
}
}
+ /**
+ * Stops a program on Flink cluster whose job-manager is configured in
this client's configuration.
+ * Stopping works only for streaming programs. Be aware, that the
program might continue to run for
+ * a while after sending the stop command, because after sources
stopped to emit data all operators
+ * need to finish processing.
+ *
+ * @param jobId
+ * the job ID of the streaming program to stop
+ * @throws ProgramStopException
+ * If the job ID in invalid (ie, is unknown or refers to a
batch job) of if sending the stop signal
+ * failed. That might be due to an I/O problem, ie, the
job-manager is unreachable.
+ */
+ public void stop(JobID jobId) throws ProgramStopException {
+ LOG.info("JobManager actor system address is " +
jobManagerAddress);
+
+ LOG.info("Starting client actor system");
+ final ActorSystem actorSystem;
+ try {
+ actorSystem =
JobClient.startJobClientActorSystem(configuration);
+ }
+ catch (Exception e) {
--- End diff --
try - catch block formatting is not consistent. Here you insert a line
break after the `}` and in another block you only insert a whitespace. I'm
slightly in favour of the `} catch (...) {` format.
> Add "stop" signal to cleanly shutdown streaming jobs
> ----------------------------------------------------
>
> Key: FLINK-2111
> URL: https://issues.apache.org/jira/browse/FLINK-2111
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Runtime, JobManager, Local Runtime,
> Streaming, TaskManager, Webfrontend
> Reporter: Matthias J. Sax
> Assignee: Matthias J. Sax
> Priority: Minor
>
> Currently, streaming jobs can only be stopped using "cancel" command, what is
> a "hard" stop with no clean shutdown.
> The new introduced "stop" signal, will only affect streaming source tasks
> such that the sources can stop emitting data and shutdown cleanly, resulting
> in a clean shutdown of the whole streaming job.
> This feature is a pre-requirment for
> https://issues.apache.org/jira/browse/FLINK-1929
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
