Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/750#discussion_r37991348
  
    --- Diff: 
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/test/java/org/apache/flink/stormcompatibility/api/FlinkTestCluster.java
 ---
    @@ -46,15 +52,24 @@ public void submitTopologyWithOpts(final String 
topologyName, final Map<?, ?> co
                        final SubmitOptions submitOpts)
                        throws Exception {
                final TestStreamEnvironment env = (TestStreamEnvironment) 
StreamExecutionEnvironment.getExecutionEnvironment();
    -           env.start(topology.getStreamGraph().getJobGraph(topologyName));
    +
    +           JobGraph jobGraph = 
topology.getStreamGraph().getJobGraph(topologyName);
    +           this.jobIdBuffer.put(topologyName, jobGraph.getJobID());
    +
    +           env.start(jobGraph);
        }
     
        @Override
        public void killTopology(final String topologyName) {
    +           this.killTopologyWithOpts(topologyName, null);
        }
     
        @Override
        public void killTopologyWithOpts(final String name, final KillOptions 
options) {
    +           // TODO: consider options
    --- End diff --
    
    Considering options will be  new feature... `KillOptions` are not supported 
yet. Comment for future reference only. Not related to this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to