tillrohrmann commented on issue #6883: [FLINK-10610] [tests] Port slot sharing cases to new codebase URL: https://github.com/apache/flink/pull/6883#issuecomment-463109196 Sorry for joining so late to the party. I actually missed this PR and accidentally opened #7689. While porting the tests, I think that we can completely remove the `SlotSharingITCase`, since the test is no longer valid. If you remove the slot sharing groups the test would pass with the new code because of the queued scheduling. The only test which I would port is the `CoLocationConstraintITCase` (#7690). Moreover, with #7676 I added some functionality for terminating and starting new `TaskExecutors` for the `MiniCluster`. I also think that `TaskManagerFailsWithSlotSharingITCase` should simply be removed since it is the same as the #7676 just with slot sharing. One could argue that slot sharing is the more common case and, therefore should be used. But then we should simply adapt #7676.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
