Xeli commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#issuecomment-466187966 @rmetzger I've change from using the Async API to the Sync API and the code is *so* much cleaner now, thank you for the nudge towards Sync API ! I've run some quick tests on a 1.6 cluster and so far so good. I'll do a more thorough test on a 1.7.2 cluster this weekend, I am especially interested in the performance. I have a few worries: The grpc calls catch all exceptions and rethrow them as unchecked exceptions. Which means I kind of hard to see what kind of exceptions are thrown that we should catch. I currently see one exception quite often: `DEADLINE_EXCEEDED` which is basically a timeout. My guess is this tail latency. My flink cluster is behind some firewalls on a gcp kubernetes cluster and we just need some higher default timeouts. I am curious if you run into the same exception. Do you think you can find someone to have a look at the `MultipleIdsMessageAcknowledgingSourceBase` (ping @StephanEwen who originally created it I think?)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
