StefanRRichter commented on a change in pull request #7866: [FLINK-11730]
[State Backends] Make HeapKeyedStateBackend follow the builder pattern
URL: https://github.com/apache/flink/pull/7866#discussion_r261997948
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/StateBackend.java
##########
@@ -220,7 +222,8 @@
kvStateRegistry,
ttlTimeProvider,
new UnregisteredMetricsGroup(),
- stateHandles);
+ stateHandles,
+ new CloseableRegistry());
Review comment:
Same here, I think this method only is reached by tests and has no
justification to exist in the interface. If production code would accidentally
call it, certain things like cancelling a restore will not work properly. I
think it is better to remove.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
