GJL commented on a change in pull request #7883: [FLINK-11781][yarn] Remove
"DISABLED" as possible value for yarn.per-job-cluster.include-user-jar
URL: https://github.com/apache/flink/pull/7883#discussion_r262099481
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java
##########
@@ -156,7 +155,6 @@ private YarnConfigOptions() {}
/** @see YarnConfigOptions#CLASSPATH_INCLUDE_USER_JAR */
public enum UserJarInclusion {
- DISABLED,
Review comment:
From Flink 1.5 to 1.7:
* If `DISABLED` is set, the job keeps failing.
* If an invalid value is set, the default value (`ORDER`) is used, and a
warning is logged (_"Configuration parameter {} was configured with an invalid
value {}. Falling back to default ({})."_).
If we would apply the PR as is, we would always log a warning (because
`DISABLED` will be considered an invalid value). You are proposing to throw an
exception with a customized message if `DISABLED` is set. This would help users
that are upgrading from 1.4 to 1.8 directly. So I could do that but I think it
makes sense to also propagate the exception for all other invalid values
instead of logging a warning. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
