StefanRRichter commented on a change in pull request #7866: [FLINK-11730] [State Backends] Make HeapKeyedStateBackend follow the builder pattern URL: https://github.com/apache/flink/pull/7866#discussion_r262111077
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/SnapshotStrategySynchronicityBehavior.java ########## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.state.heap; + +import org.apache.flink.runtime.state.RegisteredKeyValueStateBackendMetaInfo; + +/** + * Interface for synchronicity behavior of heap snapshot strategy. + * + * @param <K> The data type that the serializer serializes. + */ +interface SnapshotStrategySynchronicityBehavior<K> { + + default void finalizeSnapshotBeforeReturnHook(Runnable runnable) { + + } + + boolean isAsynchronous(); + + <N, V> StateTable<K, N, V> newStateTable( + HeapKeyedStateBackend<K> backend, Review comment: I just mean: `HeapKeyedStateBackend` already implements `InternalKeyContext` as you said. And to create new state tables we only require to have an `InternalKeyContext`, so we don't need this method to require `HeapKeyedStateBackend` if `InternalKeyContext` is already sufficient. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
