fhueske commented on issue #7754: [FLINK-11530] [docs] Support multiple 
languages for the docs framework
URL: https://github.com/apache/flink/pull/7754#issuecomment-469299578
 
 
   Hi @wuchong, thanks for splitting commit and the pointers to the variables.
   Adding the switch later makes total sense. 
   
   While browsing the website, I noticed that all links on Chinese pages that 
are defined with `{{ site.baseurl }}` are pointing to the English pages. Do you 
want to change them to use `{{ baseurl_i18n }}` (excluding image URLs) when 
translating the each page or in a bulk fashion?
   
   Either way is fine with me, so +1 to update the last commit and merge the PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to