TisonKun commented on a change in pull request #7880: [FLINK-11336][zk] Delete 
ZNodes when ZooKeeperHaServices#closeAndCleanupAllData
URL: https://github.com/apache/flink/pull/7880#discussion_r262375236
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/zookeeper/ZooKeeperHaServices.java
 ##########
 @@ -225,6 +227,12 @@ public void closeAndCleanupAllData() throws Exception {
                        exception = t;
                }
 
+               try {
+                       cleanupZooKeeperPaths();
 
 Review comment:
   For `RunningJobsRegistry` part, let's move the discussion to 
[FLINK-11813](https://issues.apache.org/jira/browse/FLINK-11813).
   
   Besides, `#closeAndCleanupAllData` can be called if user sends a shutdown 
signal via REST. I'd like to know what if in this case can a standby cluster 
clean up ha data? Since we already close and clean up blob service, it might be 
not a problem.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to