KurtYoung commented on a change in pull request #7904: [FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format URL: https://github.com/apache/flink/pull/7904#discussion_r262762245
########## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/DataFormatConverters.java ########## @@ -0,0 +1,1022 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.dataformat; + +import org.apache.flink.api.common.ExecutionConfig; +import org.apache.flink.api.common.typeinfo.BasicArrayTypeInfo; +import org.apache.flink.api.common.typeinfo.BasicTypeInfo; +import org.apache.flink.api.common.typeinfo.PrimitiveArrayTypeInfo; +import org.apache.flink.api.common.typeinfo.SqlTimeTypeInfo; +import org.apache.flink.api.common.typeinfo.TypeInformation; +import org.apache.flink.api.common.typeutils.CompositeType; +import org.apache.flink.api.java.tuple.Tuple; +import org.apache.flink.api.java.typeutils.MapTypeInfo; +import org.apache.flink.api.java.typeutils.ObjectArrayTypeInfo; +import org.apache.flink.api.java.typeutils.PojoField; +import org.apache.flink.api.java.typeutils.PojoTypeInfo; +import org.apache.flink.api.java.typeutils.RowTypeInfo; +import org.apache.flink.api.java.typeutils.TupleTypeInfo; +import org.apache.flink.api.java.typeutils.TupleTypeInfoBase; +import org.apache.flink.api.java.typeutils.runtime.TupleSerializerBase; +import org.apache.flink.table.type.InternalType; +import org.apache.flink.table.type.TypeConverters; +import org.apache.flink.table.typeutils.BaseRowTypeInfo; +import org.apache.flink.table.typeutils.BinaryArrayTypeInfo; +import org.apache.flink.table.typeutils.BinaryMapTypeInfo; +import org.apache.flink.table.typeutils.BinaryStringTypeInfo; +import org.apache.flink.types.Row; + +import java.lang.reflect.Array; +import java.sql.Date; +import java.sql.Time; +import java.sql.Timestamp; +import java.util.Collections; +import java.util.HashMap; +import java.util.Map; +import java.util.TimeZone; + +import scala.Product; + +/** + * Converters between internal data format and java format. + */ +public class DataFormatConverters { + + private static final Map<TypeInformation, DataFormatConverter> TYPE_INFO_TO_CONVERTER; + static { + Map<TypeInformation, DataFormatConverter> t2C = new HashMap<>(); + t2C.put(BasicTypeInfo.STRING_TYPE_INFO, StringConverter.INSTANCE); + t2C.put(BasicTypeInfo.BOOLEAN_TYPE_INFO, BooleanConverter.INSTANCE); + t2C.put(BasicTypeInfo.INT_TYPE_INFO, IntConverter.INSTANCE); + t2C.put(BasicTypeInfo.LONG_TYPE_INFO, LongConverter.INSTANCE); + t2C.put(BasicTypeInfo.FLOAT_TYPE_INFO, FloatConverter.INSTANCE); + t2C.put(BasicTypeInfo.DOUBLE_TYPE_INFO, DoubleConverter.INSTANCE); + t2C.put(BasicTypeInfo.SHORT_TYPE_INFO, ShortConverter.INSTANCE); + t2C.put(BasicTypeInfo.BYTE_TYPE_INFO, ByteConverter.INSTANCE); + t2C.put(BasicTypeInfo.CHAR_TYPE_INFO, CharConverter.INSTANCE); + + t2C.put(PrimitiveArrayTypeInfo.BOOLEAN_PRIMITIVE_ARRAY_TYPE_INFO, PrimitiveBooleanArrayConverter.INSTANCE); + t2C.put(PrimitiveArrayTypeInfo.INT_PRIMITIVE_ARRAY_TYPE_INFO, PrimitiveIntArrayConverter.INSTANCE); + t2C.put(PrimitiveArrayTypeInfo.LONG_PRIMITIVE_ARRAY_TYPE_INFO, PrimitiveLongArrayConverter.INSTANCE); + t2C.put(PrimitiveArrayTypeInfo.FLOAT_PRIMITIVE_ARRAY_TYPE_INFO, PrimitiveFloatArrayConverter.INSTANCE); + t2C.put(PrimitiveArrayTypeInfo.DOUBLE_PRIMITIVE_ARRAY_TYPE_INFO, PrimitiveDoubleArrayConverter.INSTANCE); + t2C.put(PrimitiveArrayTypeInfo.SHORT_PRIMITIVE_ARRAY_TYPE_INFO, PrimitiveShortArrayConverter.INSTANCE); + t2C.put(PrimitiveArrayTypeInfo.BYTE_PRIMITIVE_ARRAY_TYPE_INFO, PrimitiveByteArrayConverter.INSTANCE); + t2C.put(PrimitiveArrayTypeInfo.CHAR_PRIMITIVE_ARRAY_TYPE_INFO, PrimitiveCharArrayConverter.INSTANCE); + + t2C.put(SqlTimeTypeInfo.DATE, DateConverter.INSTANCE); + t2C.put(SqlTimeTypeInfo.TIME, TimeConverter.INSTANCE); + t2C.put(SqlTimeTypeInfo.TIMESTAMP, TimestampConverter.INSTANCE); + + t2C.put(BinaryStringTypeInfo.INSTANCE, BinaryStringConverter.INSTANCE); + + TYPE_INFO_TO_CONVERTER = Collections.unmodifiableMap(t2C); + } + + public static DataFormatConverter getConverterForTypeInfo(TypeInformation typeInfo) { + DataFormatConverter converter = TYPE_INFO_TO_CONVERTER.get(typeInfo); + if (converter != null) { + return converter; + } + + if (typeInfo instanceof BasicArrayTypeInfo) { + return new ObjectArrayConverter(((BasicArrayTypeInfo) typeInfo).getComponentInfo()); + } else if (typeInfo instanceof ObjectArrayTypeInfo) { + return new ObjectArrayConverter(((ObjectArrayTypeInfo) typeInfo).getComponentInfo()); + } else if (typeInfo instanceof MapTypeInfo) { + MapTypeInfo mapType = (MapTypeInfo) typeInfo; + return new MapConverter(mapType.getKeyTypeInfo(), mapType.getValueTypeInfo()); + } else if (typeInfo instanceof RowTypeInfo) { + return new RowConverter((RowTypeInfo) typeInfo); + } else if (typeInfo instanceof PojoTypeInfo) { + return new PojoConverter((PojoTypeInfo) typeInfo); + } else if (typeInfo instanceof TupleTypeInfo) { + return new TupleConverter((TupleTypeInfo) typeInfo); + } else if (typeInfo instanceof TupleTypeInfoBase && Product.class.isAssignableFrom(typeInfo.getTypeClass())) { + return new CaseClassConverter((TupleTypeInfoBase) typeInfo); + } else if (typeInfo instanceof BinaryArrayTypeInfo) { + return BinaryArrayConverter.INSTANCE; Review comment: Why do we need to convert between `BinaryArray` and `BinaryArrary`, same question to `BinaryMap` and `BinaryString` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
