[ 
https://issues.apache.org/jira/browse/FLINK-11825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785282#comment-16785282
 ] 

Congxian Qiu(klion26) commented on FLINK-11825:
-----------------------------------------------

[~fhueske] If you do not mind, I could help to implement this.

I think the first solution is better because we can maintain TimeCharacteristic 
in one place and we may support the other TimeCharacteristics for TTL state in 
the future.

> Resolve name clash of StateTTL TimeCharacteristic class
> -------------------------------------------------------
>
>                 Key: FLINK-11825
>                 URL: https://issues.apache.org/jira/browse/FLINK-11825
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / State Backends
>    Affects Versions: 1.7.2
>            Reporter: Fabian Hueske
>            Priority: Major
>
> The StateTTL feature introduced the class 
> \{{org.apache.flink.api.common.state.TimeCharacteristic}} which clashes with 
> \{{org.apache.flink.streaming.api.TimeCharacteristic}}. 
> This is a problem for two reasons:
> 1. Users get confused because the mistakenly import 
> \{{org.apache.flink.api.common.state.TimeCharacteristic}}.
> 2. When using the StateTTL feature, users need to spell out the package name 
> for \{{org.apache.flink.api.common.state.TimeCharacteristic}} because the 
> other class is most likely already imported.
> Since \{{org.apache.flink.streaming.api.TimeCharacteristic}} is one of the 
> most used classes of the DataStream API, we should make sure that users can 
> use it without import problems.
> These error are hard to spot and confusing for many users. 
> I see two ways to resolve the issue:
> 1. drop \{{org.apache.flink.api.common.state.TimeCharacteristic}} and use 
> \{{org.apache.flink.streaming.api.TimeCharacteristic}} throwing an exception 
> if an incorrect characteristic is used.
> 2. rename the class \{{org.apache.flink.api.common.state.TimeCharacteristic}} 
> to some other name.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to