azagrebin commented on issue #7921: [FLINK-11825][StateBackends] Resolve name 
class of StateTTL TimeCharacteristic class
URL: https://github.com/apache/flink/pull/7921#issuecomment-470568943
 
 
   At the moment, we do not have any streaming specific classes in core. Not 
sure, how good it is to move it to core now. State API classes are actually 
also relevant only for streaming at the moment but they are needed in core to 
unify function/operator API. Later, the unification might happen deeper and 
`TimeCharacteristic` can become also shared but now it is relevant only for 
streaming.
   
   I think we can stick to approach with just renaming the class. Currently, it 
has only one value which is not relevant because we support only processing 
time. 
   The `StateTtlConfig` is also annotated neither as @Public nor as 
@PublicEvolving (we should actually annotate it with @PublicEvolving, could be 
in this PR). By default, not annotated classes should be treated as @Internal 
which is not quite true for `StateTtlConfig` :)
   
   @klion26 we should also adjust the TTL docs in 
`docs/dev/stream/state/state.md` to use the renamed class.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to