walterddr commented on a change in pull request #7895:
[FLINK-11126][YARN][security] Filter out AMRMToken in TaskManager‘s credentials
URL: https://github.com/apache/flink/pull/7895#discussion_r263529807
##########
File path: flink-yarn/src/test/java/org/apache/flink/yarn/UtilsTest.java
##########
@@ -58,4 +87,84 @@ public void testDeleteApplicationFiles() throws Exception {
assertThat(files.count(), equalTo(0L));
}
}
+
+ @Test
+ public void testCreateTaskExecutorContext() throws Exception {
Review comment:
This is very much involved, I was wondering if it's better to have a
separate util method to just simply test this specific piece of removing
AM_RM_TOKEN from the credential factory. and/or move it to `flink-yarn-test`
package to have a more comprehensive testing?
e.g. add another assertion:
```
Assert.assertThat(
"AMRMToken", taskManagerRunsWithKerberos,
Matchers.is(false));
```
in `YARNSessionFIFOSecuredITCase` ??
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
