StefanRRichter commented on a change in pull request #7942: 
[FLINK-11696][checkpoint] Avoid to send mkdir requests to DFS from task side
URL: https://github.com/apache/flink/pull/7942#discussion_r264283851
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsCheckpointStorage.java
 ##########
 @@ -107,6 +105,13 @@ public CheckpointStorageLocation 
initializeLocationForCheckpoint(long checkpoint
                // prepare all the paths needed for the checkpoints
                final Path checkpointDir = 
createCheckpointDirectory(checkpointsDirectory, checkpointId);
 
+               if (!areDirectoriesCreated) {
+                       fileSystem.mkdirs(checkpointsDirectory);
 
 Review comment:
   If you want to minimize calls, this one should not even be needed because it 
would simply happen as part of the `fileSystem.mkdirs(checkpointDir);` below.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to