zhijiangW commented on a change in pull request #7713: [FLINK-10995][network]
Copy intermediate serialization results only once for broadcast mode
URL: https://github.com/apache/flink/pull/7713#discussion_r264514955
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/BroadcastRecordWriter.java
##########
@@ -44,4 +52,67 @@ public BroadcastRecordWriter(
public void emit(T record) throws IOException, InterruptedException {
broadcastEmit(record);
}
+
+ @Override
+ public void broadcastEmit(T record) throws IOException,
InterruptedException {
Review comment:
The fist version is just trying best to reuse the common codes. But it seems
not good to understand and distinguish these two writers in essential,
including `BufferBuilder` and `ChannelSelector`. Furthermore in theory the
single `BufferBuilder` seems more efficient for `BroadcastRecordWriter`. From
this point, I am willing to keep the current version if there are no better
solutions currently.
I would refactor the commit and related tests based on current idea if you
have no other concerns. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
