dawidwys commented on a change in pull request #7967: [FLINK-11449][table]
Uncouple the Expression class from RexNodes
URL: https://github.com/apache/flink/pull/7967#discussion_r264703419
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala
##########
@@ -234,21 +272,26 @@ trait ImplicitExpressionOperations {
* @param extraNames additional names if the expression expands to multiple
fields
* @return field with an alias
*/
- def as(name: Symbol, extraNames: Symbol*) = Alias(expr, name.name,
extraNames.map(_.name))
+ def as(name: Symbol, extraNames: Symbol*): Expression =
+ call(
+ AS,
+ Seq(expr) ++
Review comment:
We can prepend the `Seq`:
```
expr +: valueLiteral(name.name) +: extraNames.map(name =>
valueLiteral(name.name)): _*)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
