KurtYoung commented on a change in pull request #7958:
[FLINK-11881][table-planner-blink] Introduce code generated typed sort to blink
table
URL: https://github.com/apache/flink/pull/7958#discussion_r265407794
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/generated/NormalizedKeyComputer.java
##########
@@ -16,27 +16,18 @@
* limitations under the License.
*/
-package org.apache.flink.table.runtime.sort;
+package org.apache.flink.table.generated;
-import org.apache.flink.api.common.typeutils.TypeComparator;
-import org.apache.flink.api.common.typeutils.TypeSerializer;
import org.apache.flink.core.memory.MemorySegment;
import org.apache.flink.table.dataformat.BaseRow;
+import org.apache.flink.table.runtime.sort.BinaryInMemorySortBuffer;
/**
* Normalized key computer for {@link BinaryInMemorySortBuffer}.
* For performance, subclasses are usually implemented through CodeGenerator.
*/
public abstract class NormalizedKeyComputer {
Review comment:
use interface?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
