twalthr commented on issue #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes. URL: https://github.com/apache/flink/pull/7664#issuecomment-472739342 @sunjincheng121 good point. Maybe we should open a follow-up issue for this. I skipped this commit in order to not break SPI implementations for now (no changes in ORC format required yet). The current translation in `master` is very inconsistent, it is using its own function catalog instance and tries to map SQL to expressions arbitrarily. I hope we can do this nicer in the future. But this is not high on the priority list. What do you think?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
