[ https://issues.apache.org/jira/browse/FLINK-2372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725130#comment-14725130 ]
ASF GitHub Bot commented on FLINK-2372: --------------------------------------- Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1082#discussion_r38404434 --- Diff: flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/partitioner/RichKafkaPartitioner.java --- @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.flink.streaming.connectors.kafka.partitioner; + + +/** + * Extended Kafka Partitioner. + * It contains a prepare() method which is called on each parallel instance. + */ +public abstract class RichKafkaPartitioner implements KafkaPartitioner { + private static final long serialVersionUID = -4590784174150709918L; + + public abstract void prepare(int parallelInstanceId, int parallelInstances, int[] partitions); --- End diff -- In all other cases, the method is called `open()`. I think with that we established a bit of a terminology inside Flink, which would be good to follow here. > Update KafkaSink to use new Producer API > ---------------------------------------- > > Key: FLINK-2372 > URL: https://issues.apache.org/jira/browse/FLINK-2372 > Project: Flink > Issue Type: Task > Components: Kafka Connector > Affects Versions: 0.10 > Reporter: Robert Metzger > Assignee: Robert Metzger > Fix For: 0.10 > > > Flink's Kafka Sink is using Kafka's old Producer API, which is has very poor > performance and a limited API. > I'll implement a new KafkaSink which is using the new API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)